fix: 修正部分進貨採購單更新失敗與狀態顯示問題
All checks were successful
Koori-ERP-Deploy-System / deploy-demo (push) Successful in 50s
Koori-ERP-Deploy-System / deploy-production (push) Has been skipped

This commit is contained in:
2026-01-27 13:27:28 +08:00
parent 293358df62
commit a7c445bd3f
22 changed files with 1413 additions and 42 deletions

View File

@@ -0,0 +1,163 @@
<?php
namespace App\Modules\Inventory\Controllers;
use App\Http\Controllers\Controller;
use App\Modules\Inventory\Services\GoodsReceiptService;
use App\Modules\Inventory\Services\InventoryService;
use App\Modules\Procurement\Contracts\ProcurementServiceInterface;
use Illuminate\Http\Request;
use Inertia\Inertia;
use App\Modules\Inventory\Models\GoodsReceipt;
class GoodsReceiptController extends Controller
{
protected $goodsReceiptService;
protected $inventoryService;
protected $procurementService;
public function __construct(
GoodsReceiptService $goodsReceiptService,
InventoryService $inventoryService,
ProcurementServiceInterface $procurementService
) {
$this->goodsReceiptService = $goodsReceiptService;
$this->inventoryService = $inventoryService;
$this->procurementService = $procurementService;
}
public function index(Request $request)
{
$query = GoodsReceipt::query()
->with(['warehouse']); // Vendor info might need fetching separately or stored as snapshot if cross-module strict
if ($request->has('search')) {
$search = $request->input('search');
$query->where('code', 'like', "%{$search}%");
}
$receipts = $query->orderBy('created_at', 'desc')
->paginate(10)
->withQueryString();
// Hydrate Vendor Names (Manual hydration to avoid cross-module relation)
// Or if we stored vendor_name in DB, we could use that.
// For now, let's fetch vendors via Service if needed, or just let frontend handle it if we passed IDs?
// Let's implement hydration properly.
$vendorIds = $receipts->pluck('vendor_id')->unique()->toArray();
if (!empty($vendorIds)) {
// Check if ProcurementService has getVendorsByIds? No directly exposed method in interface yet.
// Let's assume we can add it or just fetch POs to get vendors?
// Actually, for simplicity and performance in Strict Mode, often we just fetch minimal data.
// Or we can use `App\Modules\Procurement\Models\Vendor` directly ONLY for reading if allowed, but strict mode says NO.
// But we don't have getVendorsByIds in interface.
// User requirement: "從採購單帶入".
// Let's just pass IDs for now, or use a method if available.
// Wait, I can't modify Interface easily without user approval if it's big change.
// But I just added updateReceivedQuantity.
// Let's skip vendor name hydration for index for a moment and focus on Create first, or use a direct DB query via a DTO service?
// Actually, I can use `DB::table('vendors')` as a workaround if needed, but that's dirty.
// Let's revisit Service Interface.
}
// Quick fix: Add `vendor` relation to GoodsReceipt only if we decided to allow it or if we stored snapshot.
// Plan said: `vendor_id`: foreignId.
// Ideally we should have stored `vendor_name` in `goods_receipts` table for snapshot.
// I didn't add it in migration.
// Let's rely on `ProcurementServiceInterface` to get vendor info if possible.
// I will add a method to get Vendors or POs.
return Inertia::render('Inventory/GoodsReceipt/Index', [
'receipts' => $receipts,
'filters' => $request->only(['search']),
]);
}
public function create()
{
return Inertia::render('Inventory/GoodsReceipt/Create', [
'warehouses' => $this->inventoryService->getAllWarehouses(),
// Vendors? We need to select PO, not Vendor directly maybe?
// Designing the UI: Select PO -> fills Vendor and Items.
// So we need a way to search POs by code or vendor.
// We can provide an API for searching POs.
]);
}
public function store(Request $request)
{
$validated = $request->validate([
'warehouse_id' => 'required|exists:warehouses,id',
'type' => 'required|in:standard,miscellaneous,other',
'purchase_order_id' => 'nullable|required_if:type,standard|exists:purchase_orders,id',
// Vendor ID is required if standard, but optional/nullable for misc/other?
// Stick to existing logic: if standard, we infer vendor from PO usually, or frontend sends it.
// For now let's make vendor_id optional for misc/other or user must select one?
// "雜項入庫" might not have a vendor. Let's make it nullable.
'vendor_id' => 'nullable|integer',
'received_date' => 'required|date',
'remarks' => 'nullable|string',
'items' => 'required|array|min:1',
'items.*.product_id' => 'required|integer|exists:products,id',
'items.*.purchase_order_item_id' => 'nullable|required_if:type,standard|integer',
'items.*.quantity_received' => 'required|numeric|min:0',
'items.*.unit_price' => 'required|numeric|min:0',
'items.*.batch_number' => 'nullable|string',
'items.*.expiry_date' => 'nullable|date',
]);
$this->goodsReceiptService->store($validated);
return redirect()->route('goods-receipts.index')->with('success', '進貨單已建立');
}
// API to search POs
public function searchPOs(Request $request)
{
$search = $request->input('query');
if (!$search) {
return response()->json([]);
}
$pos = $this->procurementService->searchPendingPurchaseOrders($search);
return response()->json($pos);
}
// API to search Products for Manual Entry
public function searchProducts(Request $request)
{
$search = $request->input('query');
if (!$search) {
return response()->json([]);
}
$products = $this->inventoryService->getProductsByName($search);
// Format for frontend
$mapped = $products->map(function($product) {
return [
'id' => $product->id,
'name' => $product->name,
'code' => $product->code,
'unit' => $product->unit, // Ensure unit is included
'price' => $product->purchase_price ?? 0, // Suggest price from product info if available
];
});
return response()->json($mapped);
}
// API to search Vendors
public function searchVendors(Request $request)
{
$search = $request->input('query');
if (!$search) {
return response()->json([]);
}
$vendors = $this->procurementService->searchVendors($search);
return response()->json($vendors);
}
}

View File

@@ -0,0 +1,51 @@
<?php
namespace App\Modules\Inventory\Models;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\SoftDeletes;
class GoodsReceipt extends Model
{
use HasFactory, SoftDeletes;
use \Spatie\Activitylog\Traits\LogsActivity;
protected $fillable = [
'code',
'type',
'warehouse_id',
'purchase_order_id',
'vendor_id',
'received_date',
'status',
'remarks',
'user_id',
];
protected $casts = [
'received_date' => 'date',
];
public function getActivitylogOptions(): \Spatie\Activitylog\LogOptions
{
return \Spatie\Activitylog\LogOptions::defaults()
->logAll()
->logOnlyDirty()
->dontSubmitEmptyLogs();
}
public function items()
{
return $this->hasMany(GoodsReceiptItem::class);
}
// Strict Mode: relationships to Warehouse is allowed (same module).
public function warehouse()
{
return $this->belongsTo(Warehouse::class);
}
// Strict Mode: cross-module relationship to Vendor/User/PurchaseOrder is restricted.
// They are accessed via IDs or Services.
}

View File

@@ -0,0 +1,39 @@
<?php
namespace App\Modules\Inventory\Models;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
class GoodsReceiptItem extends Model
{
use HasFactory;
protected $fillable = [
'goods_receipt_id',
'product_id',
'purchase_order_item_id',
'quantity_received',
'unit_price',
'total_amount',
'batch_number',
'expiry_date',
];
protected $casts = [
'quantity_received' => 'decimal:2',
'unit_price' => 'decimal:2', // 暫定價格
'total_amount' => 'decimal:2',
'expiry_date' => 'date',
];
public function goodsReceipt()
{
return $this->belongsTo(GoodsReceipt::class);
}
public function product()
{
return $this->belongsTo(Product::class);
}
}

View File

@@ -77,4 +77,14 @@ Route::middleware('auth')->group(function () {
Route::get('/api/warehouses/{warehouse}/inventories', [TransferOrderController::class, 'getWarehouseInventories'])
->middleware('permission:inventory.view')
->name('api.warehouses.inventories');
// 進貨單 (Goods Receipts)
Route::middleware('permission:goods_receipts.view')->group(function () {
Route::get('/goods-receipts', [\App\Modules\Inventory\Controllers\GoodsReceiptController::class, 'index'])->name('goods-receipts.index');
Route::get('/goods-receipts/create', [\App\Modules\Inventory\Controllers\GoodsReceiptController::class, 'create'])->middleware('permission:goods_receipts.create')->name('goods-receipts.create');
Route::post('/goods-receipts', [\App\Modules\Inventory\Controllers\GoodsReceiptController::class, 'store'])->middleware('permission:goods_receipts.create')->name('goods-receipts.store');
Route::get('/api/goods-receipts/search-pos', [\App\Modules\Inventory\Controllers\GoodsReceiptController::class, 'searchPOs'])->name('goods-receipts.search-pos');
Route::get('/api/goods-receipts/search-products', [\App\Modules\Inventory\Controllers\GoodsReceiptController::class, 'searchProducts'])->name('goods-receipts.search-products');
Route::get('/api/goods-receipts/search-vendors', [\App\Modules\Inventory\Controllers\GoodsReceiptController::class, 'searchVendors'])->name('goods-receipts.search-vendors');
});
});

View File

@@ -0,0 +1,109 @@
<?php
namespace App\Modules\Inventory\Services;
use App\Modules\Inventory\Models\GoodsReceipt;
use App\Modules\Inventory\Models\GoodsReceiptItem;
use App\Modules\Inventory\Contracts\InventoryServiceInterface;
use App\Modules\Procurement\Contracts\ProcurementServiceInterface;
use Illuminate\Support\Facades\DB;
class GoodsReceiptService
{
protected $inventoryService;
protected $procurementService;
public function __construct(
InventoryServiceInterface $inventoryService,
ProcurementServiceInterface $procurementService
) {
$this->inventoryService = $inventoryService;
$this->procurementService = $procurementService;
}
/**
* Store a new Goods Receipt and process inventory.
*
* @param array $data
* @return GoodsReceipt
* @throws \Exception
*/
public function store(array $data)
{
return DB::transaction(function () use ($data) {
// 1. Generate Code
$data['code'] = $this->generateCode($data['received_date']);
$data['user_id'] = auth()->id();
$data['status'] = 'completed'; // Direct completion for now
// 2. Create Header
$goodsReceipt = GoodsReceipt::create($data);
// 3. Process Items
foreach ($data['items'] as $itemData) {
// Create GR Item
$grItem = new GoodsReceiptItem([
'product_id' => $itemData['product_id'],
'purchase_order_item_id' => $itemData['purchase_order_item_id'] ?? null,
'quantity_received' => $itemData['quantity_received'],
'unit_price' => $itemData['unit_price'],
'total_amount' => $itemData['quantity_received'] * $itemData['unit_price'],
'batch_number' => $itemData['batch_number'] ?? null,
'expiry_date' => $itemData['expiry_date'] ?? null,
]);
$goodsReceipt->items()->save($grItem);
// 4. Update Inventory
$reason = match($goodsReceipt->type) {
'standard' => '採購進貨',
'miscellaneous' => '雜項入庫',
'other' => '其他入庫',
default => '進貨入庫',
};
$this->inventoryService->createInventoryRecord([
'warehouse_id' => $goodsReceipt->warehouse_id,
'product_id' => $grItem->product_id,
'quantity' => $grItem->quantity_received,
'unit_cost' => $grItem->unit_price,
'batch_number' => $grItem->batch_number,
'expiry_date' => $grItem->expiry_date,
'reason' => $reason,
'reference_type' => GoodsReceipt::class,
'reference_id' => $goodsReceipt->id,
'source_purchase_order_id' => $goodsReceipt->purchase_order_id,
'arrival_date' => $goodsReceipt->received_date,
]);
// 5. Update PO if linked and type is standard
if ($goodsReceipt->type === 'standard' && $goodsReceipt->purchase_order_id && $grItem->purchase_order_item_id) {
$this->procurementService->updateReceivedQuantity(
$grItem->purchase_order_item_id,
$grItem->quantity_received
);
}
}
return $goodsReceipt;
});
}
private function generateCode(string $date)
{
// Format: GR + YYYYMMDD + NNN
$prefix = 'GR' . date('Ymd', strtotime($date));
$last = GoodsReceipt::where('code', 'like', $prefix . '%')
->orderBy('id', 'desc')
->lockForUpdate()
->first();
if ($last) {
$seq = intval(substr($last->code, -3)) + 1;
} else {
$seq = 1;
}
return $prefix . str_pad($seq, 3, '0', STR_PAD_LEFT);
}
}